Rewrite McLachlan - Revision history

107.6.61.163: /* Failing Test Cases */

2015-07-23T13:04:34Z

‎Failing Test Cases

2015-01-05T20:37:02Z

‎Parameter Name Changes

2015-01-02T17:25:03Z

‎User-Visible Changes

2015-01-02T17:23:00Z

‎User-Visible Changes

2015-01-02T15:20:11Z

‎Parameter Name Changes

2015-01-02T15:18:51Z

‎Parameter Name Changes

2015-01-02T15:06:06Z

‎Parameter Name Changes

2015-01-02T15:05:44Z

‎Parameter Name Changes

2015-01-02T15:05:04Z

‎Parameter Name Changes

2015-01-02T15:02:59Z

‎Parameter Name Changes

←Older revision		Revision as of 13:04, 23 July 2015
Line 52:		Line 52:
	After this is done, some test cases continue to fail. These are:		After this is done, some test cases continue to fail. These are:
	* Dissipation/test_ah and Dissipation/test_ob. These test cases contain moving puncture ouput, and the details of finite differencing near the puncture change by about 10^-10 (relative difference) in the rewrite branch. Given that the metric there looks "like noise", this difference seems acceptable.		* Dissipation/test_ah and Dissipation/test_ob. These test cases contain moving puncture ouput, and the details of finite differencing near the puncture change by about 10^-10 (relative difference) in the rewrite branch. Given that the metric there looks "like noise", this difference seems acceptable.
−	* AHFinderdirect/{checkpoint,recover}ML-EE. STILL NEED TO INVESTIGATE, COULD BE THE GROUP NAME STORED IN THE CHECKPOINT FILE.

←Older revision		Revision as of 20:37, 5 January 2015
Line 44:		Line 44:
	Note:		Note:
	* dt_lapse_shift_method enabled a performance optimization that deliberately led to incorrect values for ADMBase's dtlapse and dtshift.		* dt_lapse_shift_method enabled a performance optimization that deliberately led to incorrect values for ADMBase's dtlapse and dtshift.
		+
		+	==Failing Test Cases==
		+	Most test cases can be converted in a straightforward manner, as described above:
		+	* In the list of variables and groups to be output, phi needs to be replaced by phiW, and ML_log_confac by ML_confac
		+	* Ditto In file names containing variable or group names
		+
		+	After this is done, some test cases continue to fail. These are:
		+	* Dissipation/test_ah and Dissipation/test_ob. These test cases contain moving puncture ouput, and the details of finite differencing near the puncture change by about 10^-10 (relative difference) in the rewrite branch. Given that the metric there looks "like noise", this difference seems acceptable.
		+	* AHFinderdirect/{checkpoint,recover}ML-EE. STILL NEED TO INVESTIGATE, COULD BE THE GROUP NAME STORED IN THE CHECKPOINT FILE.

@@ Line 14: / Line 14: @@
 * Parameter names change. For backward compatibility, it is still possible to use the old parameter names. At run time, the old parameters are interpreted and the new parameters are set correspondingly (if possible), and a warning is produced.
 * The grid function "phi" and its group "ML_log_confac" are renamed to "phiW" and "ML_confac". It is not possible to add a backward compatibility layer for this.
-* The parameter setting shiftGammaCoeff=0.0 is now implemented differently, leading to differences in B^i and ADMBase::dtshift^i. Since B^i is unused with this setting, these differences do not influence the time evolution of the other variables. Reproducing the previous behaviour would be possible, but would lead to less efficient code.
+* The parameter setting shiftGammaCoeff=0.0 is now implemented differently, leading to differences in B^i and ADMBase::dtbeta^i. Since B^i is unused with this setting, these differences do not influence the time evolution of the other variables. Reproducing the previous behaviour would be possible, but would lead to less efficient code.
 ==Parameter Name Changes==

@@ Line 14: / Line 14: @@
 * Parameter names change. For backward compatibility, it is still possible to use the old parameter names. At run time, the old parameters are interpreted and the new parameters are set correspondingly (if possible), and a warning is produced.
 * The grid function "phi" and its group "ML_log_confac" are renamed to "phiW" and "ML_confac". It is not possible to add a backward compatibility layer for this.
 ==Parameter Name Changes==

@@ Line 18: / Line 18: @@
 (For backward compatibility, the old parameter names are still accepted.)
-{|
+{| border="1"
 |+
 ! Old parameter name !! New parameter name

@@ Line 20: / Line 20: @@
 {|
 |+
-! old parameter name !! new parameter name
+! Old parameter name !! New parameter name
 |-
 | my_initial_data || initial_data

@@ Line 35: / Line 35: @@
 |-
 | apply_dissipation || (set epsDiss=0 instead)
 |}
 * dt_lapse_shift_method enabled a performance optimization that deliberately led to incorrect values for ADMBase's dtlapse and dtshift.

@@ Line 25: / Line 25: @@
 |-
 | my_initial_boundary_condition || initial_boundary_condition
 |}

@@ Line 19: / Line 19: @@
 {|
-|+ old parameter || new parameter
+|+
 |-
 | my_initial_data || initial_data